[FIX] Seconds not properly prevented from being negative #1310

olfek · 2024-09-17T00:29:03Z

The current code ...

Line 90 in 6511920

second += Number(UserSettings.items.offset) + 60;

... fails in these two examples:

0 - 61 + 60 < 0
59 - 120 + 60 < 0

The offset (middle value) can be as low as -300.

Authenticator/src/syncTime.ts

Line 27 in 6511920

if (Math.abs(offset) <= 300) {

So the least you can have is -241 (59 - 300), the + 60 is not enough to make a positive number.

Without this fix, in the examples given above, the effect will be:

Countdown circle animation may be out of sync with the current time step because animationDelay will be stuck at 0s.

Authenticator/src/components/Popup/EntryComponent.vue

Lines 22 to 29 in 6511920

    
                 <svg viewBox="0 0 16 16"> 
        
                   <circle 
        
                     cx="8" 
        
                     cy="8" 
        
                     r="4" 
        
                     v-bind:style="{ 
        
                       animationDuration: entry.period + 's', 
        
                       animationDelay: (sectorOffset % entry.period) + 's',

timeout class will never activate unless entry.period < 5 because the left side of the < condition will be stuck at entry.period.

Authenticator/src/components/Popup/EntryComponent.vue

Line 59 in 6511920

timeout: entry.period - (second % entry.period) < 5,

0 - 61 + 60 < 0 59 - 120 + 60 < 0 https://github.com/Authenticator-Extension/Authenticator/blob/6511920bac98576e3c97fe2d213b23e9dc899422/src/store/Accounts.ts#L90

olfek · 2024-09-17T15:32:37Z

Requesting review @Sneezry @mymindstorm

mymindstorm · 2024-09-17T22:43:40Z

It's on my to-do list, but might take me a while to get to this

olfek added 3 commits September 17, 2024 00:58

[FIX] Seconds not properly prevented from being negative

9279d0b

0 - 61 + 60 < 0 59 - 120 + 60 < 0 https://github.com/Authenticator-Extension/Authenticator/blob/6511920bac98576e3c97fe2d213b23e9dc899422/src/store/Accounts.ts#L90

Remove the now redundant + 60

9480784

Move comment

737ac3f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] Seconds not properly prevented from being negative #1310

[FIX] Seconds not properly prevented from being negative #1310

olfek commented Sep 17, 2024

olfek commented Sep 17, 2024

mymindstorm commented Sep 17, 2024

	<svg viewBox="0 0 16 16">
	<circle
	cx="8"
	cy="8"
	r="4"
	v-bind:style="{
	animationDuration: entry.period + 's',
	animationDelay: (sectorOffset % entry.period) + 's',

[FIX] Seconds not properly prevented from being negative #1310

Are you sure you want to change the base?

[FIX] Seconds not properly prevented from being negative #1310

Conversation

olfek commented Sep 17, 2024

olfek commented Sep 17, 2024

mymindstorm commented Sep 17, 2024